Process Initial MSP messages in the correct order. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CONFIG message. If this does not happen, the VTX may not register properly with the FC and potentially lose further FC MSP VTX messages. This change will ensure the initial messages are processed in order.
…VTX cms navigation less "sluggish".
|
Upon merge, this was GitHub actions build number 418. At this build, my Race V3 no longer outputs signal. Build 417 still works. Running EmuFlight on this quad, but i don't think it matters. edit: |
|
More information please. What do the build numbers refer to?
…________________________________
From: nerdCopter ***@***.***>
Sent: 14 December 2024 8:27 PM
To: hd-zero/hdzero-vtx ***@***.***>
Cc: Geoff Sim ***@***.***>; Author ***@***.***>
Subject: Re: [hd-zero/hdzero-vtx] Process Initial MSP messages in the correct order. (PR #221)
Upon merge, this was GitHub actions build number 418. At this build, my Race V3 no longer outputs signal. Build 417 still works. Running EmuFlight on this quad, but i don't think it matters.
—
Reply to this email directly, view it on GitHub<#221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEZMSIEWHPP62JHFOKAY53D2FSIDLAVCNFSM6AAAAABONRWNM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGMZTKMJUGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
https://github.com/hd-zero/hdzero-vtx/actions/runs/11662675049 |
|
Perhaps you could try the head of the VTX source code and let me know the results.
As I don't know EmuFlight, I don't know what the MSP contract is between EmuFlight and the VTX.
I have tested my changes against iNav and BetaFlight and they work as expected.
Betaflight requires a V1 MSP_CONFIG message to be sent continuously to the FC.
It might be that EmuFlight is using the same message flow as BetaFlight.
Contact me on Discord (geoffsim) and I can send you an updated VTX firmware to test.
(assuming EmuFlight responds to an MSP_FC_VARIANT request of "EMUF" ?)
Failing that, I will have to look into EmuFlight for testing purposes.
Geoff.
…________________________________
From: nerdCopter ***@***.***>
Sent: 15 December 2024 5:01 PM
To: hd-zero/hdzero-vtx ***@***.***>
Cc: Geoff Sim ***@***.***>; Author ***@***.***>
Subject: Re: [hd-zero/hdzero-vtx] Process Initial MSP messages in the correct order. (PR #221)
Merge pull request #222 from geoffsim/VTX-Config-Processing
hdzero-vtx build #418: Commit 544f87e pushed by ligenxxxx
https://github.com/hd-zero/hdzero-vtx/actions/runs/11662675049
—
Reply to this email directly, view it on GitHub<#221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEZMSIHXKCNIBOBKF4NTRPL2FWYXFAVCNFSM6AAAAABONRWNM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHE2DSNZVGM>.
You are receiving this because you authored the thread.
|
Merged
|
All aforementioned personal issues solved by #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, the initial MSP_VARIANT message MUST be processed before the MSP_VTX_CONFIG message.
If this does not happen, the VTX will/may not register properly with the FC and potentially discard further MSP messages.
This change will ensure the initial messages are processed in order.
Process Initial MSP messages in the correct order.