完成JSON #144
Open
完成JSON #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARKbreeze
commented
Feb 27, 2020
ARKbreeze
commented
- 这个PR解答了当前仓库中的题目（机器人会自动判题并合并当前PR）
- 这个PR修复了当前仓库中的一些代码缺陷（机器人不会判题，而是由管理员来处理当前PR）
|
🎉 感谢提交Pull Request！请稍等片刻，我们已经将其提交到CI进行检查，一旦有结果会立即通知您！ |
|
你的提交 8926aed ，似乎失败了：Your tests failed on CircleCI 😅 请不要气馁，仔细分析原因，再接再厉！ |
1 similar comment
|
你的提交 8926aed ，似乎失败了：Your tests failed on CircleCI 😅 请不要气馁，仔细分析原因，再接再厉！ |
hcsp-bot
reviewed
Feb 28, 2020
| @@ -10,4 +10,43 @@ | |||
|
|
|||
| /** 分数 */ | |||
| private int score; | |||
|
|
|||
| private boolean fail; | |||
There was a problem hiding this comment.
这个fail是多余的。还记得么，Java Bean的属性只看getter/setter，不看字段。因此，直接在isFail()方法里return score<60;即可。
|
你少提交了pom.xml所以没有通过CI检查。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.