-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14.6 #225
Open
sltap
wants to merge
2
commits into
hcsp:master
Choose a base branch
from
sltap:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
14.6 #225
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 18 additions & 18 deletions
36
src/main/java/com/github/hcsp/polymorphism/NameCollector.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
package com.github.hcsp.polymorphism; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
import java.util.function.Consumer; | ||
|
||
public class NameCollector implements Consumer<User> { | ||
private final List<String> names = new ArrayList<>(); | ||
|
||
@Override | ||
public void accept(User user) { | ||
names.add(user.getName()); | ||
} | ||
|
||
public List<String> getNames() { | ||
return names; | ||
} | ||
} | ||
//package com.github.hcsp.polymorphism; | ||
// | ||
//import java.util.ArrayList; | ||
//import java.util.List; | ||
//import java.util.function.Consumer; | ||
// | ||
//public class NameCollector implements Consumer<User> { | ||
// private final List<String> names = new ArrayList<>(); | ||
// | ||
// @Override | ||
// public void accept(User user) { | ||
// names.add(user.getName()); | ||
// } | ||
// | ||
// public List<String> getNames() { | ||
// return names; | ||
// } | ||
//} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
package com.github.hcsp.polymorphism; | ||
|
||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.function.Consumer; | ||
|
||
public class User { | ||
/** 用户ID,数据库主键,全局唯一 */ | ||
|
@@ -26,13 +28,33 @@ public String getName() { | |
// 这里使用了一个NameCollector类,请尝试将它改写成匿名内部类 | ||
// 使得代码更加集中,更加容易阅读 | ||
public static List<String> collectNames(List<User> users) { | ||
NameCollector collector = new NameCollector(); | ||
users.forEach(collector); | ||
return collector.getNames(); | ||
// NameCollector collector = new NameCollector(); | ||
// users.forEach(collector); | ||
// return collector.getNames(); | ||
List<String> names=new ArrayList<>(); | ||
users.forEach(new Consumer<User>(){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
public void accept(User user){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
names.add(user.name); | ||
} | ||
}); | ||
return names; | ||
} | ||
|
||
public static void main(String[] args) { | ||
List<User> users = Arrays.asList(new User(1, "a"), new User(2, "b")); | ||
System.out.println(collectNames(users)); | ||
} | ||
// private static class NameCollector implements Consumer<User> { | ||
// private final List<String> names = new ArrayList<>(); | ||
// | ||
// @Override | ||
// public void accept(User user) { | ||
// names.add(user.getName()); | ||
// } | ||
// | ||
// public List<String> getNames() { | ||
// return names; | ||
// } | ||
// } | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'=' 后应有空格。
'=' 前应有空格。