Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:factory create #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/main/java/com/github/hcsp/encapsulation/Cat.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,33 @@ public class Cat {
* @param name 名字
* @return 创建的猫
*/
public static Cat newCat(String name, int age) {}
private Cat (String name,int age) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

',' 后应有空格。

this.name = name;
this.age = age;
}
public static Cat newCat(String name, int age) {
if(name == null || age < 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'if' 后应有空格。

return INVALID_CAT;
}else{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'}' 后应有空格。
'else' 后应有空格。
'else' 前应有空格。
'{' 前应有空格。

return new Cat(name,age);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用一个空格分隔非空白字符。
',' 后应有空格。

}

}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public int getAge() {
return age;
}

public void setAge(int age) {
this.age = age;
}

}