使用了策略模式对代码进行重构，使业务与打折策略分离。 #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengdasan
commented
Nov 22, 2019
chengdasan
commented
- 这个PR解答了当前仓库中的题目（机器人会自动判题并合并当前PR）
- 这个PR修复了当前仓库中的一些代码缺陷（机器人不会判题，而是由管理员来处理当前PR）
|
🎉 感谢提交Pull Request！请稍等片刻，我们已经将其提交到CI进行检查，一旦有结果会立即通知您！ |
|
你的提交 63b3c21 ，似乎失败了：Your tests failed on CircleCI 😅 请不要气馁，仔细分析原因，再接再厉！ |
1 similar comment
|
你的提交 63b3c21 ，似乎失败了：Your tests failed on CircleCI 😅 请不要气馁，仔细分析原因，再接再厉！ |
hcsp-bot
reviewed
Nov 22, 2019
| @@ -7,8 +7,9 @@ | |||
| // OnlyVipDiscountStrategy 只有VIP打95折，其他人保持原价 | |||
| // 重构后的方法签名： | |||
| // public static int calculatePrice(DiscountStrategy strategy, int price, User user) | |||
| public static int calculatePrice(String discountStrategy, int price, User user) { | |||
| switch (discountStrategy) { | |||
| public static int calculate(DiscountStrategy strategy, int price, User user) { | |||
There was a problem hiding this comment.
Suggested change
| public static int calculate(DiscountStrategy strategy, int price, User user) { | |
| public static int calculatePrice(DiscountStrategy strategy, int price, User user) { |
为什么改名字啊。。。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.