error and warning tracker (separate) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC-Dap
reviewed
Nov 14, 2023
ersilia/core/tracking.py
Outdated
| @@ -27,6 +44,7 @@ def write_persistent_file(contents): | |||
| with open(PERSISTENT_FILE_PATH, "a") as f: | |||
| f.write(f"{contents}\n") | |||
|
|
|||
| log_files_metrics(TEMP_FILE_LOGS) | |||
There was a problem hiding this comment.
Can you actually move this into close_persistent_file instead? I know I said it should be in this method, but I think it makes more sense to only run when we're closing the file instead.
ersilia/core/tracking.py
Outdated
|
|
||
| with open(file, "r") as file: | ||
| for line in file: | ||
| if "ERROR" in line: |
There was a problem hiding this comment.
Just a reminder to update this so it only checks if "ERROR" is at the beginning of the line.
ersilia/core/tracking.py
Outdated
| elif "WARNING" in line: | ||
| warning_count += 1 | ||
|
|
||
| print(f"Error count: {error_count}") |
There was a problem hiding this comment.
Can you swap out print with write_persistent_file instead?
AC-Dap
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the log_files_metrics function that keeps track of the error and warnings in the log files separately and prints the results.