Move pin configuration to YAML #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add MIN and MAX definitions to support ESP32 (non-C3)
hberntsen
added a commit
that referenced
this pull request
Dec 6, 2024
For #6, this initialisation code contains most of the pin definitions. Moving this code to here will make it easier to convert the pins to parameters.
|
Thanks for the PR! I've shuffled things around a bit, all the setters of individual pins still feel a bit janky but as far as I can see that's how components in esphome do it. I've updated the master branch, does that work for you? I've moved the pin settings from climate to the |
|
Works for my ESP32-C3. Had to add these lines for ESP32 (non-C3) as it does not have the clk_src field. |
|
Ah nice, will cherry-pick that one!
…On 7 December 2024 00:29:23 CET, Rob ***@***.***> wrote:
Works for my ESP32-C3. Had to add these lines for ESP32 (non-C3) as it does not have the clk_src field.
93b76b6
--
Reply to this email directly or view it on GitHub:
#6 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
ESP32 (non C3) does not have clk_src
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional yaml config to override the pins. Default config is what used to be hard coded to maintain backwards compatibility with old configurations.
I'm not a programmer, my code is probably janky af but it works.