Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise Mode Editing Capabilities #1444

Open
wants to merge 107 commits into
base: dev
Choose a base branch
from
Open

Conversation

russell-rozenbaum
Copy link

@russell-rozenbaum russell-rozenbaum commented Dec 18, 2024

TL;DR
Exercise Mode is fully (mostly) editable

Added Features
Adds ability to edit all* Exercise Mode features:

  • Title
  • Module name
  • Prompt
  • Mutation Tests
  • Implementation Tests
    *Still need to add editing for Syntax Tests

Also adds BlankExercise.ml for a completely blank exercise spec. Might be useful when creating new exercise button... just make sure to change UUID.

Not Bugs, but Relatively Important Things for Editing an Exercise

  • Cannot edit mutation test hints
  • Cannot add/remove Syntax Validation tests
  • Cannot edit Syntax Validation test hints
  • Cannot edit Implementation Grading test hints

russell-rozenbaum and others added 30 commits June 13, 2024 13:14
…ser is editing title, also automated swapping between focus on title-box/editors
…es, this also solves issue of text-box with incorrect value persisting across exercise slides when switching while editing
…hen switching between exercise slides; added confirm and cancel edit buttons for finalizing title updates (or cancelling them), this also fixes a bug with pressing enter to confirm where it would also press enter in the respective code editor where the cursor was located
…to-do: allow editing of implementation hints as they default to "no hint available"
…to-do: allow editing of implementation hints as they default to "no hint available
… : string, version : int) pairs; edited title now saves on refresh
@russell-rozenbaum russell-rozenbaum marked this pull request as draft December 20, 2024 01:34
@russell-rozenbaum russell-rozenbaum marked this pull request as ready for review December 20, 2024 21:34
@facundoy
Copy link
Contributor

facundoy commented Dec 20, 2024

Found the following visual bug:

  • Confirmation and Cancel buttons are not displaying properly in editing mode for Implementation Grading and Test Validation

@russell-rozenbaum russell-rozenbaum marked this pull request as draft December 21, 2024 00:30
@russell-rozenbaum russell-rozenbaum marked this pull request as ready for review December 21, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants