-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exercise Mode Editing Capabilities #1444
Open
russell-rozenbaum
wants to merge
107
commits into
dev
Choose a base branch
from
title-editor-2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,026
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te while in instructor mode
…ser is editing title, also automated swapping between focus on title-box/editors
…es, this also solves issue of text-box with incorrect value persisting across exercise slides when switching while editing
…hen switching between exercise slides; added confirm and cancel edit buttons for finalizing title updates (or cancelling them), this also fixes a bug with pressing enter to confirm where it would also press enter in the respective code editor where the cursor was located
… are non-functional still)
…to-do: allow editing of implementation hints as they default to "no hint available"
…to-do: allow editing of implementation hints as they default to "no hint available
…s to be set off read-only
… : string, version : int) pairs; edited title now saves on refresh
… and load added/deleted mutants
… and load added/deleted mutants
… and load added/deleted mutants
…ul for newly created exercises
…not being handled properly
… unnamed. without this, unnamed module exported as .txt files rather than .ml files
Found the following visual bug:
|
…guard for min req tests in test validation
…er than hint when editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Exercise Mode is fully (mostly) editable
Added Features
Adds ability to edit all* Exercise Mode features:
*Still need to add editing for Syntax Tests
Also adds BlankExercise.ml for a completely blank exercise spec. Might be useful when creating new exercise button... just make sure to change UUID.
Not Bugs, but Relatively Important Things for Editing an Exercise