Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove req_value from evaluator #1426

Closed
wants to merge 1 commit into from
Closed

Conversation

Negabinary
Copy link
Contributor

I noticed we don't really use req_value any more in the evaluator, because we mostly rely on unboxing which gives us finer-grained control.

e.g. [?] is not a value, but that doesn't mean we can't do list operations on it, so evaluation shouldn't be waiting for sub-expressions to be values, they should only check whether they can unbox the desired kind of value.

ValueChecker is staying because we still use it in $v stepper filter patterns.

@Negabinary Negabinary changed the base branch from dev to editor-output December 4, 2024 18:24
@Negabinary
Copy link
Contributor Author

closed in favor of #1433

@Negabinary Negabinary closed this Dec 5, 2024
@Negabinary Negabinary deleted the kill-req-value branch December 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant