sets DeviceType.Unknown as default value

only when DeviceType is not in the enum.
hayribakici · Nov 21, 2023 · beca6f7 · beca6f7
1 parent 8914227
commit beca6f7
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/lib/src/models/_models.g.dart b/lib/src/models/_models.g.dart
diff --git a/lib/src/models/device.dart b/lib/src/models/device.dart
@@ -32,6 +32,7 @@ class Device extends Object {
 
   /// [DeviceType], such as [DeviceType.Computer], [DeviceType.Smartphone] or
   /// [DeviceType.Speaker].
+  @JsonKey(unknownEnumValue: DeviceType.Unknown)
   DeviceType? type;
 
   /// The current volume in percent. This may be `null`.

diff --git a/test/data/v1/me/player/devices.json b/test/data/v1/me/player/devices.json
@@ -8,6 +8,15 @@
             "name": "My fridge",
             "type": "Computer",
             "volume_percent": 100
+        },
+        {
+            "id": "5fbb3ba6aa454b5534c4ba43a8c7e8e45a63ad0e",
+            "is_active": true,
+            "is_private_session": true,
+            "is_restricted": true,
+            "name": "SamsungGalaxy S3",
+            "type": "SmartWatch",
+            "volume_percent": 100
         }
     ]
 }
diff --git a/test/spotify_test.dart b/test/spotify_test.dart
@@ -268,14 +268,18 @@ Future main() async {
 
     test('Devices', () async {
       var result = await spotify.player.devices();
-      expect(result.length, 1);
+      expect(result.length, 2);
       expect(result.first.id, '5fbb3ba6aa454b5534c4ba43a8c7e8e45a63ad0e');
       expect(result.first.isActive, true);
       expect(result.first.isRestricted, true);
       expect(result.first.isPrivateSession, true);
       expect(result.first.name, 'My fridge');
       expect(result.first.type, DeviceType.Computer);
       expect(result.first.volumePercent, 100);
+
+      // the second entry does not have a valid [DeviceType], 
+      // and should have `Unknown` instead.
+      expect(result.last.type, DeviceType.Unknown);
     });
 
     test('recentlyPlayed', () async {