Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use precompiled nifs #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

use precompiled nifs #26

wants to merge 4 commits into from

Conversation

ayrat555
Copy link
Contributor

No description provided.

@ayrat555
Copy link
Contributor Author

@Hajto hey. can you please take a look?

@Hajto Hajto requested a review from ejscunha September 12, 2023 10:38
@Hajto Hajto requested review from ZuraGuerra and removed request for ejscunha September 12, 2023 10:39
@Hajto
Copy link
Contributor

Hajto commented Sep 12, 2023

You have my blessing in terms of deps. @ZuraGuerra Can you share some thoughts regarding the action changes?

@ayrat555 Do you mind sharing thoughts about why these changes were needed?

@Hajto
Copy link
Contributor

Hajto commented Sep 12, 2023

@ayrat555 I assume this pr invalidates https://github.com/hawku-com/ex_web3_ec_recover/pull/16/files ??

@ayrat555
Copy link
Contributor Author

You have my blessing in terms of deps. @ZuraGuerra Can you share some thoughts regarding the action changes?

@ayrat555 Do you mind sharing thoughts about why these changes were needed?

Now all nifs are using rustler_precompiled . rust doesn't have to be installed on the host machine anymore

@ayrat555 I assume this pr invalidates https://github.com/hawku-com/ex_web3_ec_recover/pull/16/files ??

yes, 100%. I forgot about it to be honest

@DennisDv24 DennisDv24 mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hajto Hajto Hajto approved these changes

@ZuraGuerra ZuraGuerra Awaiting requested review from ZuraGuerra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayrat555 @Hajto