Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HxSidebar Toggler v2 #667

Merged
merged 6 commits into from
Dec 15, 2023
Merged

HxSidebar Toggler v2 #667

merged 6 commits into from
Dec 15, 2023

Conversation

crdo
Copy link
Member

@crdo crdo commented Nov 19, 2023 •
edited by hakenr
Loading

@hakenr I have implemented a new HxSidebar Toggler inspired by chat.openai.com.
It is little more minimalistic and shows a tooltip on hover.

What needs to be done

  • Get rid of ExpandIcon and CollapseIcon paramters
  • Add resources for Expand/Collapse text in tooltip
  • Cleanup the CSS with some variables so it is a bit more cleaner and configurable

I would like to make it into next major release.

@crdo crdo changed the title Toggler v2 WIP HxSidebar Toggler v2 WIP Nov 19, 2023
@hakenr hakenr marked this pull request as ready for review December 15, 2023 14:42
hakenr
hakenr approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hakenr hakenr merged commit c840fcf into master Dec 15, 2023
1 check passed
@hakenr hakenr changed the title HxSidebar Toggler v2 WIP HxSidebar Toggler v2 Dec 15, 2023
@hakenr hakenr deleted the feature/HxSidebarNewToggler branch December 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakenr hakenr hakenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crdo @hakenr