Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): add missing import androidx.core.app.ActivityCompat #331

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

erisu
Copy link

@erisu erisu commented Dec 10, 2024

Motivation and Context

Resolve "PushPlugin.kt:616:13 Unresolved reference: ActivityCompat"

Description

Added missing import for androidx.core.app.ActivityCompat

Related Issue

n/a

Reported in comment: #325 (comment)

How Has This Been Tested?

Created blank android project, added plugin, and run build.

  • confirmed issue without PR changes
  • confirmed that the issue has been was resolved with PR changes

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu added bug Something isn't working android Related to the Android platform labels Dec 10, 2024
@erisu erisu added this to the 5.0.2 milestone Dec 10, 2024
@erisu erisu merged commit db61727 into master Dec 10, 2024
7 checks passed
@erisu erisu deleted the fix/android-add-missing-import-ActivityCompat branch December 10, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Related to the Android platform bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant