Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): update reset flags placement in notificationReceived #329

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

erisu
Copy link

@erisu erisu commented Dec 9, 2024

Motivation and Context

Fix the placement of when the reset flags are applied. And update of #319

Description

Move the reset flags into the condition when notificationMessage and callbackId exists.

Related Issue

n/a

How Has This Been Tested?

Tested pushing a payload in all states (background, foreground, inactive).
Confirmed that the coldstart and foreground flags continue to display correctly in payload.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu changed the title fix(ios): notificationReceived - reset flags if message & callback exist fix(ios): update reset flags placement in notificationReceived Dec 9, 2024
@erisu erisu merged commit 41ef28d into master Dec 9, 2024
7 checks passed
@erisu erisu deleted the fix/ios-reset-flag branch December 9, 2024 04:03
@erisu erisu restored the fix/ios-reset-flag branch December 9, 2024 05:37
@erisu erisu deleted the fix/ios-reset-flag branch December 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant