Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): revert accidental change to category "callback" #328

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

erisu
Copy link

@erisu erisu commented Dec 9, 2024

Motivation and Context

Fix an accidental breaking property name change from callback to identifier.
Fix issue where category's callback was not being property set and triggered.

Description

In the documentation and typings, the CategoryActionData object should include a key named callback.

On iOS, the native code refers to callback as identifier. Because of this, the native implementation was mistakenly modified to extract the callback value using the incorrect key identifier.

This PR reverts the key back to callback to align with the documentation and typings.

The issue was discovered during testing of the typings.

Updated code to make sure that the actionCallback is not removed in cases where the value is not default.

Related Issue

n/a

How Has This Been Tested?

  • Confirmed that the callback is triggered when clicking the category option.
  • Tested the default, category, & actionCallback case while app state is in Foreground, Background, & Inactive

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu changed the title fix(ios): revert an accidental change to iOS's action property key 'c… fix(ios): revert accidental property name change for "callback" Dec 9, 2024
@erisu erisu force-pushed the fix/ios-callback-identifier-key branch from 2e22e22 to 8f29f19 Compare December 9, 2024 05:38
@erisu erisu changed the title fix(ios): revert accidental property name change for "callback" fix(ios): revert accidental change to category "callback" Dec 9, 2024
@erisu erisu merged commit 0a7d5bc into master Dec 9, 2024
7 checks passed
@erisu erisu deleted the fix/ios-callback-identifier-key branch December 9, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant