fix(ios): revert accidental change to category "callback" #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix an accidental breaking property name change from
callback
toidentifier
.Fix issue where category's
callback
was not being property set and triggered.Description
In the documentation and typings, the
CategoryActionData
object should include a key namedcallback
.On iOS, the native code refers to
callback
asidentifier
. Because of this, the native implementation was mistakenly modified to extract thecallback
value using the incorrect keyidentifier
.This PR reverts the key back to
callback
to align with the documentation and typings.The issue was discovered during testing of the typings.
Updated code to make sure that the actionCallback is not removed in cases where the value is not default.
Related Issue
n/a
How Has This Been Tested?
callback
is triggered when clicking the category option.Screenshots (if appropriate):
Types of changes
Checklist: