refactor: Splitting FCMService.kt file into multiple files; some cleanup too #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody! 🤩,
This PR comes in preparation of some additional features we'd like to the Library from our codebase.
It is basically only moving things around to be able to work better with the code.
Description
We split
FCMService.ktinto some smaller service files andMotivation and Context
We want to be able to merge some new fixes from our Repo back to the mainline.
Mostly this is related to VoIP Calls / allowing for Pushes to show a call dialog in the future on Android.
How Has This Been Tested?
Types of changes
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.I have added tests to cover my changes.new andexisting tests passed.