Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android)!: bump platform requirement cordova-android>=12.0.0 #243

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

erisu
Copy link

@erisu erisu commented Sep 28, 2023

Description

Bump cordova-android engine requirement

Related Issue

n/a

Motivation and Context

Since Android 13 (SDK 33) APIs are being added to the source code, we should increase the cordova-android requirement to >=12.0.0 which supports SDK 33 minimum.

Anything lower will not build successfully out of the box.

How Has This Been Tested?

plugin add

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu merged commit 9169e81 into master Sep 28, 2023
@erisu erisu deleted the feat/bump-cordova-android-requirement branch September 28, 2023 13:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant