Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning example for CoxPH loss #78

Open
wants to merge 10 commits into
base: refactor_out_torchtuples
Choose a base branch
from

Conversation

rohanshad
Copy link

Minimal example of CoxPH loss working with pytorch lightning in lightning_coxph.py. I've separately built this into my other scripts with integration within the torch lightning test step logic for easier logging. I decided not to do that here since that requires dataset specific transformations / logging with tensorboard.

Made some other small changes to docstrings too.

@havakv
Copy link
Owner

havakv commented Mar 21, 2021

Great work!
Ideally one would have created branch with only changes relative to refactor_out_torchtuples, as now there are some duplicate commits. I don't think that is a big issue here, but something to think about in the future as a clean commit history is always beneficial (git rebase is a great tool for this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants