Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max_age of session cookies to 8h instead of 3 months #1

Open
wants to merge 1 commit into
base: 13.0
Choose a base branch
from
Open

Update max_age of session cookies to 8h instead of 3 months #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions odoo/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,12 +1157,12 @@ def load_request_data(self):

def session_gc(session_store):
if random.random() < 0.001:
# we keep session one week
last_week = time.time() - 60*60*24*7
# we keep session 8h
exp_time = time.time() - 60*60*8
for fname in os.listdir(session_store.path):
path = os.path.join(session_store.path, fname)
try:
if os.path.getmtime(path) < last_week:
if os.path.getmtime(path) < exp_time:
os.unlink(path)
except OSError:
pass
Expand Down Expand Up @@ -1400,7 +1400,7 @@ def get_response(self, httprequest, result, explicit_session):
# - It could allow session fixation attacks.
if not explicit_session and hasattr(response, 'set_cookie'):
response.set_cookie(
'session_id', httprequest.session.sid, max_age=90 * 24 * 60 * 60, httponly=True)
'session_id', httprequest.session.sid, max_age=8 * 60 * 60, httponly=True)

return response

Expand Down