Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the TS SDK to 1.2.4 and fixing incorrectly required insert_schema field in mutations #78

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

sordina
Copy link
Contributor

@sordina sordina commented Nov 27, 2023

Previously required format:

curl http://localhost:8100/mutation -H 'content-type: application/json' -d '{"insert_schema":[],"operations":[{"type":"procedure","name":"hello","arguments":{}}],"collection_relationships":{}}' -vvv | jq .

Now supports:

curl http://localhost:8100/mutation -H 'content-type: application/json' -d '{"operations":[{"type":"procedure","name":"hello","arguments":{}}],"collection_relationships":{}}' -vvv | jq .

This was brought to our attention by @soorajshankar who found that the engine was no longer sending through the insert_schema field and the SDK validation was throwing an error.

Follow up actions:

  • Improve SDK logging to output exact validation failures to logs to more easily identify this kind of issue

@sordina sordina changed the title Updating the TS SDK to 1.2.4 and fixing incorrectly required insert_schema bug Updating the TS SDK to 1.2.4 and fixing incorrectly required insert_schema field in mutations Nov 27, 2023
@sordina sordina self-assigned this Nov 27, 2023
Copy link
Member

@soorajshankar soorajshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks Lyndon!

@sordina sordina merged commit 83a2a35 into main Nov 27, 2023
1 check passed
@daniel-chambers daniel-chambers deleted the lyndon/update-ts-sdk-1.2.4-insert-schema-bug branch December 4, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants