Updates for DDN Alpha and TypeScript Deno connector compatibility #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sordina
approved these changes
Nov 29, 2023
| { | ||
| "deno.enable": true, | ||
| "deno.lint": true, | ||
| "deno.unstable": false |
There was a problem hiding this comment.
We're using unstable features in the connector to support the NPM modules so should we try to match this with the dev tools?
There was a problem hiding this comment.
I'm not sure that refers to that, I think this enables access to Deno's unstable APIs. I've used an NPM package (for testing) in this project with that set to false and it works just fine.
| COPY ./functions /functions/src | ||
|
|
||
| # Pre-cache inference results and dependencies | ||
| RUN PRECACHE_ONLY=true /app/entrypoint.sh |
|
I tested this against DDN Production and it returns a response that is making the engine choke.
More investigation required before merging. |
daniel-chambers
force-pushed
the
daniel/update-for-latest-connector
branch
from
75d3ba7 to
cc37e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates this repo to be compatible with the DDN Alpha and also with the latest TypeScript Deno connector compatibility (namely the improved watch support, introduced in hasura/ndc-typescript-deno#79).
errorsproperty is not nullable/undefined on the return object, because the TypeScript Deno connector doesn't support nullable/undefined types properly yetconfig.jsonfile deleted and an empty config just inlined into the CLI commands in the readmeextensions.jsonhas been added to recommend the required VSCode extensionssettings.jsonadded to ensure Deno extension is activated in this repo