update ndc-spec from 0.1.0-rc.13 to 0.1.0-rc.14 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupi
commented
Feb 5, 2024
| @@ -355,6 +369,7 @@ fn get_field_type(column_type: &models::Type, schema: &models::SchemaResponse) - | |||
| nullable: matches!(**element_type, models::Type::Nullable { .. }), | |||
| }) | |||
| } | |||
| models::Type::Predicate { .. } => todo!(), | |||
There was a problem hiding this comment.
Not sure about this one.
soupi
changed the title
soupi
changed the title
added 2 commits
February 13, 2024 14:32
This reverts commit a7dab56.
soupi
changed the title
SamirTalwar
approved these changes
Feb 14, 2024
github-merge-queue bot
pushed a commit
to hasura/ndc-postgres
that referenced
this pull request
Feb 14, 2024
- depends on: hasura/ndc-hub#93 - todo: add changelog entry ### What We are updating connector to support the latest ndc-connector spec (0.1.0-rc14). While fixing some breaking changes, such as renaming `where` to `predicate`, we also support new capabilities: 1. Explaining mutations via the `/mutation/explain` endpoint 2. Supporting filtering using `in` by columns and variables ### How 1. Since a mutation request may contain multiple mutation operations, the explain response will contain a field named `<operation_name> SQL Mutation` and a field named `<operation_name> Execution Plan` for each operation. 2. To filter in column or variable, we need to compare against a subquery of the shape `(select value from unnest(<column-or-variable>) as table(value))`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.