Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: trace propagation implementation #51

Merged
merged 3 commits into from
Oct 3, 2023
Merged

chore: trace propagation implementation #51

merged 3 commits into from
Oct 3, 2023

Conversation

danieljharvey
Copy link
Contributor

@danieljharvey danieljharvey commented Oct 3, 2023 •
edited
Loading

This PR implements trace propagation, adds a MakeSpan trait that grab any traceparent and tracestate headers, and injecting them into span context. The result is that requests from v3-engine show up in NDC agents as follows:

Screenshot 2023-09-29 at 12 52 35

The implementation is taken from ndc-multitenant for consistency.

Also resolves #43 , by not specifying a tracing level, the defaults make 2xx responses into INFO and 4xx and 5xx into ERROR.

@danieljharvey danieljharvey mentioned this pull request Oct 3, 2023
Closed
@danieljharvey danieljharvey requested a review from i-am-tom October 3, 2023 09:36
@danieljharvey danieljharvey merged commit 3248df5 into main Oct 3, 2023
3 checks passed
@danieljharvey danieljharvey deleted the djh/copy-trace-propagation-from-multitenant branch October 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-am-tom i-am-tom i-am-tom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attach STATUS_CODE_ERROR to traces for non-successful requests
2 participants
@danieljharvey @i-am-tom