Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add region_routing in validate_raw_configuration #39

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

paritosh-08
Copy link
Contributor

Description

This PR adds region_routings as an argument to validate_raw_configuration. The validate_raw_configuration is supposed to create Configuration from RawConfiguration, but Configuration needs region_routings, which is not there in RawConfiguration.

This PR also adds functions to extract read and write regions from Configuration.

Please note that this is required for the multi-region routing project (see specs here)

add functions to extract read and write regions from `Configuration`
@paritosh-08 paritosh-08 requested a review from sordina September 16, 2023 06:28
@paritosh-08 paritosh-08 self-assigned this Sep 16, 2023
Copy link
Contributor

@sordina sordina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@paritosh-08 paritosh-08 merged commit 13ac364 into main Sep 16, 2023
3 checks passed
@SamirTalwar SamirTalwar deleted the multi-region-routing branch March 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants