-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector publishing automation #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scriptnull
reviewed
Aug 12, 2024
scriptnull
reviewed
Aug 12, 2024
scriptnull
reviewed
Aug 12, 2024
scriptnull
reviewed
Aug 12, 2024
@@ -0,0 +1,104 @@ | |||
# Connector registry Github packaging | |||
|
|||
This is a Work-In-Progress document. Please provide any feedback you wish to contribute via Github comments and suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to remove "Work-In-Progress"
scriptnull
reviewed
Aug 12, 2024
scriptnull
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is the first PR towards adding automating the publishing of a new connector version. The scope of this PR is limited to the following and further changes will be made in future PRs. More on the automation process here
The scope of the PR is limited to the following:
registry
folder according to the format specified in the doc will only be deployed to staging. This is basically to test the whole worklow. After that, we will enable the publishing process to prod after a PR is merged to themain
branch.registry/<connector_name>/releases
), changes to an existing version are not covered (I'm not sure if this is useful to do anyways, since a release that has already been made never changes).README.md
andlogo.png
changes will be made in a separate PR.How does the automation work?
main
branch, we get the list of files that have been added, modified and deleted. In this PR, we only use the list of added files.ndc-postgres
releasesv2.0.0
, then one of the added files would beregistry/postgres/releases/v2.0.0/connector-packaging.json
, the name and version of the connector are parsed from the file path.connector-packaging.json
file to get the URI of the connector metadata.Future work
registry
folder according to the proposed structure in the RFC, we can enable the workflow in prod after a PR is merged to themain
branch.README.md
and thelogo.png
.