Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the v2 compatibility routes. #116

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

SamirTalwar
Copy link
Contributor

It seems that no one is using these any more.

It seems that no one is using these any more.
Copy link
Collaborator

@BenoitRanque BenoitRanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this go

@BenoitRanque
Copy link
Collaborator

I think we can also remove the dependency on the v2 rust types

@SamirTalwar SamirTalwar merged commit de1ad71 into main Mar 11, 2024
5 checks passed
@SamirTalwar SamirTalwar deleted the samirtalwar/delete-v2-compat branch March 11, 2024 09:48
@paf31
Copy link
Collaborator

paf31 commented Mar 11, 2024

This is referenced here: https://hasura.io/docs/3.0/connectors/v2-compatibility

How are we making these decisions to remove features?

@SamirTalwar
Copy link
Contributor Author

I asked around if anyone was using this and did not get any affirmatives, or anyone pointing out that it's useful. I didn't know about the docs.

Happy to restore them if they're useful. I will put them under a Cargo feature so we can avoid the gdc_rust_types dependency in ndc-postgres, and update the docs accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants