Skip to content

Commit

Permalink
Use FromNamedImage
Browse files Browse the repository at this point in the history
  • Loading branch information
paf31 committed Feb 9, 2024
1 parent d6156b3 commit 880051a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rfcs/0000-deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Here is a sketch of the data structure in Rust:

```rust
pub enum ConnectorBuildRequest {
FromHubConnector {
FromNamedImage {
name: String,
version: Version, // sha hash
},
Expand All @@ -70,6 +70,6 @@ pub enum ConnectorBuildRequest {

How this structure gets built by CLI (or its supporting web service) is out of scope. For example, we might fetch tar bundles from Git repos, or from the filesystem. Dockerfiles might be under the user's control, or not. But this structure is what is required to build images for deployment.

In the case of `FromHubConnector`, the expectation is that the connector build service maintains a list of prebuilt images, indexed by the names and versions of hub connectors.
In the case of `FromNamedImage`, the expectation is that the connector build service maintains a list of prebuilt images, indexed by the names and versions of supported connectors.

Here, in the case of `FromHubConnector`, a full directory containing a `Dockerfile` and any supporting build inputs is provided as the bytes of a `.tar` file, but the exact protocol can be up to the service implementer.

0 comments on commit 880051a

Please sign in to comment.