update to fix timestamp and bigint/hugeint filters #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paf31
reviewed
Nov 5, 2024
| break; | ||
| case "_neq": | ||
| sql = `${expression.column.name} != ?`; | ||
| sql = isTimestamp | ||
| ? `${escape_double(expression.column.name)} != CAST(? AS TIMESTAMP)` |
There was a problem hiding this comment.
This could be refactored to pull the right hand side of the operator out into an expression which is computable only from the type, and reused. The left hand side seems to always be the same.
paf31
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix filtering for bigint and timestamp by handling cast