Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-variables-again #24

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Fix-variables-again #24

merged 5 commits into from
Aug 17, 2024

Conversation

BenoitRanque
Copy link
Collaborator

This PR removes top level group by and order by clauses.
The order by has no effect, and the group by is actually incorrect here.

The group by was erroneously added because it was required for the order by, which itself should not have been there.

This meant foreach queries would return multiple rows, which was not desired behavior.

@BenoitRanque BenoitRanque requested a review from codedmart August 17, 2024 13:21
@BenoitRanque BenoitRanque merged commit a5df7ec into main Aug 17, 2024
3 checks passed
@BenoitRanque BenoitRanque deleted the fix-variables-again branch August 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants