Fix capabilities version, upgrade SDK to v0.1.4, fix Clippy lints #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
daniel-chambers
commented
Jul 31, 2024
|
|
||
| pub fn capabilities() -> models::CapabilitiesResponse { | ||
| models::CapabilitiesResponse { | ||
| version: "^0.1.1".to_string(), |
There was a problem hiding this comment.
This was the boo boo. 😭
BenoitRanque
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a fairly significant bug in the capabilities response, where the connector returns an invalid version. It returns a semver range, rather than just a semantic version, which is against the spec. It's probably a holdover from an old version of the spec that never got changed.
This has caused issues now that engine actually looks at the value in that property.
The PR also updates the NDC Rust SDK to the latest easily updatable version (v0.1.4). A more recent version brings in new newtypes that I'm not prepared to deal with for this small fix.
The PR also fixes all the various clippy lint warnings across the code (in separate commit for easier reviewing).