disallow pushing with warnings

hasura · Sep 6, 2024 · ad77d13 · ad77d13
1 parent 8722ddd
commit ad77d13
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 14 deletions.
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
@@ -9,11 +9,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          # this defaults to "-D warnings", making warnings fail the entire build.
-          # setting to empty strng to allow builds with warnings
-          # todo: consider removing this, and disallowing pushing with warnings?
-          rustflags: ""
       - run: cargo test --all-features
 
   # Check formatting with rustfmt
@@ -26,9 +21,5 @@ jobs:
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
           components: rustfmt
-          # this defaults to "-D warnings", making warnings fail the entire build.
-          # setting to empty strng to allow builds with warnings
-          # todo: consider removing this, and disallowing pushing with warnings?
-          rustflags: ""
       - name: Rustfmt Check
         uses: actions-rust-lang/rustfmt@v1
diff --git a/.github/workflows/security-audit.yaml b/.github/workflows/security-audit.yaml
@@ -8,11 +8,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          # this defaults to "-D warnings", making warnings fail the entire build.
-          # setting to empty strng to allow builds with warnings
-          # todo: consider removing this, and disallowing pushing with warnings?
-          rustflags: ""
       # we don't use the audit-check action, because it overwrites our lockfile before checking
       # ref: https://github.com/rustsec/audit-check/issues/15
       # todo: once that is fixed, move to audit-check, and set up regular audit check on top of these PR ones