Merge pull request #13 from hasura/fix/resultset-ordering

fix ordering of result sets
hasura · Apr 10, 2024 · 9717568 · 9717568
2 parents 6b349d7 + 6e46882
commit 9717568
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.2.3]
+
+- Fix ordering of result sets for foreach queries (remote joins)
+
 ## [0.2.2]
 
 - Return error if empty list of query variables passed. Variables should be ommited or be a list with at least one member

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -6,5 +6,5 @@ members = [
 ]
 resolver = "2"
 
-package.version = "0.2.2"
+package.version = "0.2.3"
 package.edition = "2021"
diff --git a/crates/ndc-clickhouse/src/sql/query_builder.rs b/crates/ndc-clickhouse/src/sql/query_builder.rs
@@ -193,7 +193,7 @@ impl<'r, 'c> QueryBuilder<'r, 'c> {
         let order_by = if self.request.variables.is_some() {
             vec![OrderByExpr {
                 expr: Expr::CompoundIdentifier(vec![
-                    Ident::new_quoted("_rowset"),
+                    Ident::new_quoted("_vars"),
                     Ident::new_quoted("_varset_id"),
                 ]),
                 asc: Some(true),