Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict access to fullscreen labs directly from an URL #297

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mrtmm
Copy link
Contributor

@mrtmm mrtmm commented Nov 13, 2024

Add more authentication checks when acessing a fullscreen lab direclty from an URL. Return a 401 when the user is not authenticated in the platfrom.

@mrtmm mrtmm requested a review from fghaas November 13, 2024 10:38
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (541d4c2) to head (406cd8b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          24       24           
  Lines        1979     1979           
=======================================
  Hits         1890     1890           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I have just one suggestion.

hastexo/hastexo.py Show resolved Hide resolved
Add more authentication checks when acessing a fullscreen lab
direclty from an URL. Return a 401 when the user is not
authenticated in the platfrom.
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me now! Please go ahead and merge.

hastexo/hastexo.py Show resolved Hide resolved
@mrtmm mrtmm merged commit 406cd8b into hastexo:master Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants