Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE RUB: Corrected Validation exception for Modify #811

Conversation

rcruzfreelance
Copy link
Contributor

Closes #571

@ShriHumrudha
Copy link
Collaborator

I am thinking out loud if we want to keep the data arranging explicit in the test for the storytelling.

@hassanhabib
Copy link
Owner

I am thinking out loud if we want to keep the data arranging explicit in the test for the storytelling.

@ShriHumrudha we can also expose an input parameter for dates - either way is okay.

@mtoncic
Copy link
Contributor

mtoncic commented Nov 18, 2021

I am thinking out loud if we want to keep the data arranging explicit in the test for the storytelling.

@ShriHumrudha we can also expose an input parameter for dates - either way is okay.

Fill like free to jump since I created an issue.
In the proposed solution there is a version:

  DateTimeOffset createdAndUpdatedDate = DateTimeOffset.UtcNow;
  Student randomStudent= CreateRandomStudent(dates: createdAndUpdatedDate);
  Student invalidStudent = randomStudent;

I think that this would be the right match.

@hassanhabib
Copy link
Owner

hassanhabib commented Nov 20, 2021

I am thinking out loud if we want to keep the data arranging explicit in the test for the storytelling.

@ShriHumrudha we can also expose an input parameter for dates - either way is okay.

Fill like free to jump since I created an issue. In the proposed solution there is a version:

  DateTimeOffset createdAndUpdatedDate = DateTimeOffset.UtcNow;
  Student randomStudent= CreateRandomStudent(dates: createdAndUpdatedDate);
  Student invalidStudent = randomStudent;

I think that this would be the right match.

@mtoncic that's a bad version. The dates here are generated from the datetime instead of random. We should randomize instead. The reason for the randomization here is to ensure that nobody is adding some crazy rule that says only throw exception if dates are the same AND recent. We don't want to do that for any reason.

@hassanhabib
Copy link
Owner

Closing this due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants