Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Button Helpers (input_button) #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drewsteinacher
Copy link

Translations from Google Translate.


Starting in Home Assistant 2022.4, button helpers have existed under input_button:

These are currently not searchable in HASS.Agent. I have tried to add them here, but I only have a development environment set up on my Ubuntu machine, and have struggled to get a fully successful build there. Apologies if I have messed up something.

Translations from Google Translate.
@amadeo-alex
Copy link
Collaborator

Hello, thank you for the PR!

and have struggled to get a fully successful build there

Can you elaborate on that :D?

@drewsteinacher
Copy link
Author

Hi @amadeo-alex, since HASS.Agent is a Windows application, building it on Linux has been a bit challenging.

Specifically, I had to make the following changes to get it to at least build partially. This might be an incomplete list, as it was somewhat intrusive (adjustments to all .csproj files) and is unrelated to my PR's changes, and it was a few weeks ago when I was trying it out.

In HASS.Agent.csproj:

  • Add <TargetFramework>net6.0-windows</TargetFramework>
  • Add <EnableWindowsTargeting>true</EnableWindowsTargeting>
  • Bump Microsoft.WindowsAppSDK in HASS.Agent.csproj to above 1.5 for this build issue

In HASS.Agent.Satellite.Service.csproj:

  • Add <EnableWindowsTargeting>true</EnableWindowsTargeting>

In HASS.Agent.Shared.csproj:

  • Add <EnableWindowsTargeting>true</EnableWindowsTargeting>
  • Add the following to avoid issues finding Windows forms workloads (?):
  <ItemGroup>
    <KnownFrameworkReference Update="Microsoft.WindowsDesktop.App" IsWindowsOnly="false" />
    <KnownFrameworkReference Update="Microsoft.WindowsDesktop.App.WPF" IsWindowsOnly="false" />
    <KnownFrameworkReference Update="Microsoft.WindowsDesktop.App.WindowsForms" IsWindowsOnly="false" />
  </ItemGroup>

This allows me to build the satellite service project and the shared project (with warnings of course), but the HASS.Agent project itself errors out complaining of various package downgrades and incompatible packages that I don't have time to dig into right now.

If I sort it out, I'll happily make a separate PR though so others can at least build/develop on Linux, but it seems unlikely at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants