-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests for CLC proposal: Modify displayed exception type #86
Conversation
CI is currently failing due to a glibc mismatch:
2.27 (and 2.28, for that matter) are quite old, and so is the ubuntu runner Edit: Updating the runner (or checkout to |
Create
We had to do this with some of our packages, too: |
Thanks! PR incoming. |
The following two proposals add exception type info to the output of displayException: haskell/core-libraries-committee#231 haskell/core-libraries-committee#261 This commit updates the test output here to match: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12242
@wz1000 now that CI is passing, might you be able to merge this one? |
@wz1000 @andreasabel does anyone of you feel comfortable to merge? The CLC proposal has been approved a month ago, so I don't think the change of baseline is controversial. |
Well, I could merge it, but I could not retrieve evidence of its correctness: The affected test case
To me it looks like one or more tests are in a broken state and I do not even get to see the result of test |
If you update https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12242 to point to the same commit (e9e9aaa) and the GHC CI passes, I think we can merge this. |
MR has been updated to the current commit here and CI passing. |
Thanks @wz1000! |
Now that the CLC proposal has been approved, this can be merged.
haskell/core-libraries-committee#261.
See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12242.
Obviates #81.