Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chanbench.hs #85

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Remove chanbench.hs #85

merged 1 commit into from
Apr 10, 2024

Conversation

hamishmack
Copy link
Contributor

Fixes #84

@hamishmack
Copy link
Contributor Author

hamishmack commented Apr 9, 2024 •
edited
Loading

I could not find anything in this repo that referred to chanbench.hs. I assume it is something that is run manually?

It would be good to get this PR merged as the file name clash will cause problems calculating nix hashes on macOS systems (which normally have case insensitive filesystems).

@hsyl20
Copy link
Contributor

hsyl20 commented Apr 10, 2024 •
edited
Loading

I think you can just remove the file.

  • chanbench.hs was renamed into ChenBench.hs in 9821578
  • this commit was partially reverted in 110318a, reintroducing chanbench.hs for no reason afaict (cc @bgamari)

@hamishmack hamishmack changed the title Rename chanbench.hs to runtest.hs Remove chanbench.hs Apr 10, 2024
@hsyl20 hsyl20 mentioned this pull request Apr 10, 2024
Closed
@bgamari bgamari merged commit 7bf9d68 into haskell:master Apr 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This repo is broken on case-insensitive systems
3 participants
@hamishmack @hsyl20 @bgamari