Correctly pass VersionedTextDocumentIdentifier through hls #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
requested review from
isovector,
konn,
santiweight,
OliverMadine,
eddiemundo,
Ailrun and
berberman
as code owners
|
Okay, I can confirm, that the failing edits happen in files with CPP and the error log clearly shows that it is because of the CPP. |
|
I still need to fix compilation with wingman. |
michaelpj
approved these changes
Jun 11, 2023
| getFileEdit = flip $ getSrcEdit state . replaceRefs newName | ||
| fileEdits <- mapM (uncurry getFileEdit) filesRefs | ||
| getFileEdit (uri, locations) = do | ||
| verTxtDocId <- lift $ getVersionedTextDoc (TextDocumentIdentifier uri) |
There was a problem hiding this comment.
I think this may well fix the rename plugin to work properly if one of the files that we rename in has been changed in the editor!
There was a problem hiding this comment.
Yeah, I had the feeling that I am fixing a bug here.
| @@ -124,6 +124,7 @@ data FileContext = FileContext | |||
| , fc_range :: Maybe (Tracked 'Current Range) | |||
| -- ^ For code actions, this is 'Just'. For code lenses, you'll get | |||
| -- a 'Nothing' in the request, and a 'Just' in the response. | |||
| , textVersion :: TextDocumentVersion | |||
There was a problem hiding this comment.
looks like there's a URI field too, so can we just make it a VTDI?
| @@ -622,12 +622,13 @@ mkWorkspaceEdits | |||
| :: DynFlags | |||
| -> ClientCapabilities | |||
| -> Uri | |||
| -> TextDocumentVersion | |||
maralorn
force-pushed
the
with-version-identifier
branch
from
5b38d24 to
b6f4c66
Compare
|
I think there was a transient test error on windows. Can we maybe restart it? |
This was referenced Jun 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at a continuation of #3566 because I don’t have rights to push to that branch.
Sadly, while I can’t reproduce the concrete error message we are trying to fix here. There are still a lot of files in which hlint fixes don’t get applied for me.