Use Map with custom FromJSON to ignore unknown keys in GHCupInfo #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatibility This is a Map with custom FromJSON instance that will allow an older ghcup to parse metadata containing new Platform/Architecture types in Map keys
This is for use in ghcup-metadata validation code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very straightforward change to replace the usage of
MapinGHCupInfo.we only ever need the behavior of
Mapwhen doing validation of metadata in ghcup-metadata repo.And we do need two set of instances for parsing JSON, so using a compile flag to select that looks like a fairly decent design choice while keeping code clear from parameterized data types.