-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have projects import trimmed URIs #10629
Conversation
Will need a changelog but otherwise it looks like the right direction overall. |
4ebca6f
to
e27511e
Compare
Huh. First time I've seen RTD fail that way. |
And I didn't change the docs. @geekosaur, other CI jobs I can restart but not that one. |
That's normal, since RTD isn't actually part of GitHub Actions. You'll need to change something somewhere to trigger a new build, though. (You may want to hold off a bit though, to let RTD fix whatever's wrong on their end.) |
50b9a2e
to
f719178
Compare
f719178
to
52978ba
Compare
@geekosaur I've included a W3C quote about URLs in the changelog and added the bug label to this pull request as it fixes a bug. |
3e644b1
to
6c087fb
Compare
6c087fb
to
fc70bfd
Compare
@Mikolaj this is a bug fix in need of a second reviewer. Do you think we can get it into the upcoming release? |
Uh, what upcoming release? I'm not sure it qualifies for 3.14.1.1. |
@geekosaur I had a hunch there was a release coming up based on bumped version numbers and pull requests being expedited. Is there somewhere where plans for upcoming releases are posted? |
The recently bumped version number was actually missed for 3.14.1.0, and is currently being considered severe enough that we'll push a 3.14.1.1 quickly. But as I understand it, we aren't planning to include any other fixes, just this mistake. The expedited pull requests are all for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Kleidukos is the 3.14.* release manager so up them if/when to include this fix.
Why not include it for a cabal 3.14.2.0, but not for 3.14.1.1 :) |
ed1e8c9
to
78e1e51
Compare
- Trim before isURI check for canonicalizeConfigPath - Show path quoted if not already trimmed - Trim before checking with parseURI
- Error if an untrimmed URI is detected - Add a changelog - Add UntrimmedImport tests - Soften the error down to a warning - Use with-ghc.config trick - Add fix-whitespace exceptions for test projects - Include W3C quote is changelog - Remove unused LANGUAGE pragma - Rerun test now that URL imports are sorted last - Move test underneath ProjectImport parent dir
78e1e51
to
f6c3a43
Compare
Label merge+no rebase is necessary when the pull request is from an organisation. |
Fixes #10622. Trims URIs before parsing them with
parseURI
. If any project config path doesn't equal its trimmed self then it is displayed quoted so that the whitespace is obvious.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.cabal-testsuite
tests.