reorder Haddock markup for dynprof constructor #10226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ulysses4ever
approved these changes
Jul 23, 2024
|
I have to admit that I don't know why the problem doesn't show in CI, only in local validate. |
|
One of our Windows tests is flapping… in the opposite direction from usual: an unexpected pass. https://github.com/haskell/cabal/actions/runs/10067368968/job/27830681823#step:20:384 |
Mikolaj
approved these changes
Jul 24, 2024
geekosaur
added
merge me
mergify
bot
added
the
merge delay passed
Older ghcs don't like it being after the constructor.
Mikolaj
force-pushed
the
old-ghcs-haddock-dynprof
branch
from
d30f63d to
cee1f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older ghcs don't like it being after the constructor: #10092 (comment)
Template B: This PR does not modify behaviour or interface
(N.B. while this doesn't change interface, it corrects an error in #9900 which very much does.)
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: