-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: install changelog-d from bindist #10048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
And this should be expedited (exempt from the two-days delay).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@mergify backport 3.12 |
✅ Backports have been created
|
@Mergifyio refresh |
This will avoid build problems when the GHC in the CI environment is updated sooner than expected. Previous breakage: haskell#9177 (comment)
55625cc
to
4f85c1d
Compare
✅ Pull request refreshed |
It's one commit so we can squash, no? |
pr:squash label doesn't do anything magical, it's just a reminder to squash manually if the branch is protected and the bot can't do that by itself. But in this case, no squashing is needed exactly because there's just one commit (and the branch is not protected either). So, the label isn't needed either. Current status: the branch was rebased on master by the bot, and the CI has to re-run and complete before the bot will merge it to master. If no one removes the necessary labels (merge-me, merge delay passed) that is. |
Yeah sorry I made a bit of a mess with labels. I think it makes sense to also squash-merge prs with a single commit, since there isn't anything to group up, but feel free to revert the label change |
I don't know if 1-commit PRs squashed look the same as merged. They probably are, and in that case, it doesn't matter which label to use. |
The squash per se does nothing since there's nothing to squash. The only significant difference is whether it does a merge or a rebase to get it into ETA: looks like our |
They look different: |
Oh, I prefer the former very much. I wish I understood why it works like that. Also, can we set it up so that it never creates these ugly merge commit? (Or am I the only one who doesn't like them?..)
hmm, this looks like it should behave the opposite to what fgaz describes in the quote above?.. I'm so confused! |
I noticed that as well. What I see in the git log is that |
Yes! |
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters).
This will avoid build problems when the GHC in the CI environment is updated sooner than expected. Previous breakage: #9177 (comment) (cherry picked from commit d1a6ced) # Conflicts: # .github/workflows/changelogs.yml
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters).
This will avoid build problems when the GHC in the CI environment is updated sooner than expected. Previous breakage: haskell#9177 (comment)
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters).
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters). We now use `squash` instead of `rebase`, so the PR number is preserved for `changelog-d` to find.
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters). We now use `squash` instead of `rebase`, so the PR number is preserved for `changelog-d` to find.
This will avoid build problems when the GHC in the CI environment is updated sooner than expected. Previous breakage: haskell#9177 (comment)
Per haskell#10048 (comment) ff. In studying the Mergify documentation, I discovered the actual rules are slightly different than the ones we thought it was using, so I used the ones the documentation cited (cf. https://docs.mergify.com/workflow/actions/merge/#parameters). We now use `squash` instead of `rebase`, so the PR number is preserved for `changelog-d` to find.
* CI: install changelog-d from bindist (#10048) This will avoid build problems when the GHC in the CI environment is updated sooner than expected. Previous breakage: #9177 (comment) (cherry picked from commit d1a6ced) # Conflicts: # .github/workflows/changelogs.yml * !fixup resolve conflicts --------- Co-authored-by: Francesco Gazzetta <[email protected]> Co-authored-by: Artem Pelenitsyn <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This will avoid build problems when the GHC in the CI environment is updated sooner than expected.
Previous breakage: #9177 (comment)
Template B: This PR does not modify behaviour or interface
Include the following checklist in your PR: