Bump @vscode/extension-telemetry to 0.8.0
#1483
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Jun 12, 2023
| @@ -48,7 +48,7 @@ let crashCount = 0; | |||
|
|
|||
| export async function activate(context: vscode.ExtensionContext): Promise<void> { | |||
| const manifest = context.extension.packageJSON; | |||
| reporter = new TelemetryReporter(context.extension.id, manifest.version, manifest.appInsightsKey); | |||
| reporter = new TelemetryReporter(manifest.appInsightsKey); | |||
There was a problem hiding this comment.
Where does it get the extension ID & version from now? Is that automagically read at runtime from package.json or something?
There was a problem hiding this comment.
With 0.7.5 they removed the need to provide these parameters. I assume the new VS Code telemetry API handles this internally.
There was a problem hiding this comment.
As long as you confirmed the VS Code telemetry API handles that and the events land in AppInsights in the expected shape (i.e. under the expected ID & version), then 👍🏻 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the telemetry library to the latest version. Due to some breaking changes, I had to make some minor changes.
Error tracking now requires a custom event name. Please have a look at the strings I came up with.