Adds KV PATCH support via 'update' methods. #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- Add KV#update for patch support - Add Logical#update for patch support - Limit #update specs to vault >= 1.9.0 - Add vault 1.9.2 and ruby 2.7.4 to test matrix - Update spec to match on custom_metadata for vault >= 1.9.0
|
LGTM. Great job Phillip! |
|
Anything that we can do to help this one moving forward ? |
|
No one seems to care... I'm closing this just to stop from seeing it on my Github pages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
updatemethod toKVto allow for patching paths as described here:https://www.vaultproject.io/api-docs/secret/kv/kv-v2#patch-secret
It also adds an
updatemethod toLogicalto allow for patching paths as well. I did this for parity, but I'm not entirely sold on it as versioning requires the path start withdatawhich the KV class does automatically, but Logical does not. I could easily be talked into removing that from this PR.