Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customising the service accounts used by the injector agent, and the CSI provider #676

Closed
wants to merge 2 commits into from

Conversation

todd-dev
Copy link

This PR adds support for customising the service accounts used by the:

  • Injector agent
  • CSI provider

It extends the work done in #367 and #338.
It completes #328 (which was half completed by the previous PRs), and it fixes #426.

It seems to overlap with #494 though, which covers the injector service account.

I also stumbled across a bug - which has already been raised as #606, and I believe that is also fixed by this PR.

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

@tvoran tvoran added csi Area: The CSI provider portion of the chart enhancement New feature or request injector Area: mutating webhook service labels Jan 12, 2022
@tvoran
Copy link
Member

tvoran commented Jan 12, 2022

Hi @todd-dev, thanks for digging into this, and just a friendly reminder to sign the CLA when you have a chance: https://www.hashicorp.com/cla

@tvoran tvoran added the waiting for response Waiting for a response from the author label Jan 12, 2022
@heatherezell
Copy link

Hi @todd-dev, thanks for digging into this, and just a friendly reminder to sign the CLA when you have a chance: https://www.hashicorp.com/cla

To add to this, the bot looks for your GitHub handle / email address used to sign the CLA. For corporate CLAs, your GitHub organization needs to be publicly viewable and your handle matches what was signed. Please holler if you have any issues!

@toddbfz
Copy link

toddbfz commented Jan 13, 2022

I will be double-checking the CLA with my employer.
I just wanted to gauge interest in the PR before spending too much time on that, thanks!

@heatherezell
Copy link

@toddbfz It's my job to be interested in a PR! However, if you would like dedicated space to discuss your solution with the engineers, please feel free to open a related issue. :)

@todd-dev
Copy link
Author

CLA signed :)

@heatherezell heatherezell removed the waiting for response Waiting for a response from the author label Jan 14, 2022
@toddbfz
Copy link

toddbfz commented Jul 28, 2022

@hsimon-hashicorp @tvoran Is there interest in this PR? It has sat waiting for quite a while. If there is, I'll bring it up to date with main.
Thanks :)

@todd-dev
Copy link
Author

Closing out of lack of interest

@todd-dev todd-dev closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csi Area: The CSI provider portion of the chart enhancement New feature or request injector Area: mutating webhook service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the vault injection serviceAccount name a configuration option
5 participants