Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix config templating #1073

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Nov 13, 2024

Adds support back for templating the server config (inadvertently removed in #1049).

Fixes #1072

@tvoran tvoran added this to the v0.30.0 milestone Nov 13, 2024
@tvoran tvoran requested a review from a team as a code owner November 13, 2024 18:29
Copy link

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benashz benashz self-requested a review November 20, 2024 15:12
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that!

@benashz benashz added the regression fix Fixes a regression bug. label Nov 20, 2024
@tvoran tvoran merged commit 87d6789 into main Nov 20, 2024
7 checks passed
@tvoran tvoran deleted the VAULT-32492/fix-server-templating branch November 20, 2024 16:38
@tvoran tvoran modified the milestones: v0.30.0, v0.29.1 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression fix Fixes a regression bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config no longer templates properly
3 participants