Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Quick Checks be skipped if a PR updates only the CHANGELOG or version/VERSION files #36215

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make Quick Checks be skipped if a PR updates only the CHANGELOG or version/VERSION files #36215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3a5707
Make Quick Checks be skipped if a PR updates only the CHANGELOG or ve…
SarahFrench Dec 13, 2024
ca83bcd
Skip 'Quick Checks' on push when editing only release-related files
SarahFrench Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,19 @@ on:
- ready_for_review
- reopened
- synchronize
paths-ignore:
# Stop quick checks if the PR contains changes limited to just these files
- 'CHANGELOG.md'
- 'version/VERSION'
push:
branches:
- '*'
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
paths-ignore:
# Stop quick checks if the PR contains changes limited to just these files
- 'CHANGELOG.md'
- 'version/VERSION'
Comment on lines 29 to +37
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this stops the check running on the commit made when the PR is merged, so this PR will need to be updated with triggers specific to different subsets of branches (paths-ignore for pushes to contributors' branches, no ignoring for pushes to branches like main and vX.X.X)


# This workflow runs for not-yet-reviewed external contributions and so it
# intentionally has no write access and only limited read access to the
Expand Down
Loading