Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for vtpm #2279

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: add support for vtpm #2279

merged 1 commit into from
Oct 16, 2024

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Oct 8, 2024 •
edited
Loading

Description

Added Support for vTPM on creation and clone of virtual machine.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_basic$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	1.076s

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_hardwareVersionBare$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.981s

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereVirtualMachine_addDevices$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	0.983s

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Closes #1599

@burnsjared0415 burnsjared0415 added the breaking-change Status: Breaking Change label Oct 8, 2024
@burnsjared0415 burnsjared0415 added this to the v2.9.3 milestone Oct 8, 2024
@burnsjared0415 burnsjared0415 self-assigned this Oct 8, 2024
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Oct 8, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch from c57f8a9 to b2faf2f Compare October 8, 2024 14:00
tenthirtyam
tenthirtyam reviewed Oct 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tenthirtyam
tenthirtyam reviewed Oct 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch from b2faf2f to 8ff8be1 Compare October 8, 2024 14:56
tenthirtyam
tenthirtyam requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial small changes - will wait for your update and the CI to pass. :)

@tenthirtyam tenthirtyam changed the title feat: r/vsphere_virtual_machine add support for vTPM feat: add support for vtpm Oct 8, 2024
@tenthirtyam tenthirtyam modified the milestones: v2.9.3, On Deck Oct 8, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch 2 times, most recently from 7cb1360 to d28111d Compare October 8, 2024 16:44
@tenthirtyam tenthirtyam modified the milestones: On Deck, v2.10.0 Oct 8, 2024
@tenthirtyam tenthirtyam removed the breaking-change Status: Breaking Change label Oct 8, 2024
tenthirtyam
tenthirtyam requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional suggested changes to review for checking the status of the firmware and the removal of a function that isn't used at this time.

@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch from d28111d to ef72ac1 Compare October 8, 2024 20:57
@tenthirtyam tenthirtyam marked this pull request as ready for review October 8, 2024 21:56
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 8, 2024 21:56
@tenthirtyam tenthirtyam force-pushed the feat/add_support_for_vtpm branch from ef72ac1 to da9ecd7 Compare October 8, 2024 21:56
tenthirtyam
tenthirtyam approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and our offline demo was great.

@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch from 0c20a9f to 2f5946c Compare October 9, 2024 13:06
tenthirtyam
tenthirtyam reviewed Oct 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tenthirtyam
tenthirtyam requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

@burnsjared0415 burnsjared0415 force-pushed the feat/add_support_for_vtpm branch from 2f5946c to a07a3e7 Compare October 9, 2024 15:44
@burnsjared0415 burnsjared0415 added the enhancement Type: Enhancement label Oct 10, 2024
@tenthirtyam tenthirtyam force-pushed the feat/add_support_for_vtpm branch 3 times, most recently from 1e40ed8 to cd21396 Compare October 11, 2024 17:48
tenthirtyam
tenthirtyam approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Oct 11, 2024
@burnsjared0415 @tenthirtyam
feat: r/vsphere_virtual_machine add support for vTPM
8505bf5 
Added support for virtual Trusted Platform Module (`vtpm`) on creation and clone of virtual machine.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feat/add_support_for_vtpm branch from cd21396 to 8505bf5 Compare October 16, 2024 17:57
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Oct 16, 2024
@tenthirtyam tenthirtyam merged commit 952f6cb into hashicorp:main Oct 16, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

This functionality has been released in v2.10.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@spacegospod spacegospod Awaiting requested review from spacegospod

Assignees

@burnsjared0415 burnsjared0415

Labels
documentation Type: Documentation enhancement Type: Enhancement provider Type: Provider
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Add support for vTPM
3 participants
@burnsjared0415 @tenthirtyam @iBrandyJackson