Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: r/vsphere_tag_category cardinality #2263

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Sep 17, 2024

Description

There was a bug that resulted in the tag being replaced when changing cardinality from Single to Multiple, I have remove the ForceNew.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Running tool: /usr/local/bin/go test -timeout 30s -run ^TestAccResourceVSphereTagCategory_basic$ github.com/hashicorp/terraform-provider-vsphere/vsphere

ok  	github.com/hashicorp/terraform-provider-vsphere/vsphere	(cached)

Release Note

r/vsphere_tag_category: Updates resource not to ForceNew for cardinality. This will allow the tag_category to updated.

References

Closes #1959

@burnsjared0415 burnsjared0415 self-assigned this Sep 17, 2024
@github-actions github-actions bot added provider Type: Provider needs-review Status: Pull Request Needs Review labels Sep 17, 2024
@burnsjared0415 burnsjared0415 added this to the v2.9.3 milestone Sep 17, 2024
@tenthirtyam tenthirtyam added the bug Type: Bug label Sep 17, 2024
@tenthirtyam tenthirtyam self-requested a review September 17, 2024 20:59
@tenthirtyam tenthirtyam changed the title bug: r/vsphere_tag_category fix cardinality fix: r/vsphere_tag_category cardinality Sep 17, 2024
@burnsjared0415 burnsjared0415 changed the title fix: r/vsphere_tag_category cardinality fix: r/vsphere_tag_category cardinality Sep 17, 2024
@tenthirtyam tenthirtyam changed the title fix: r/vsphere_tag_category cardinality fix: r/vsphere_tag_category cardinality Sep 17, 2024
@burnsjared0415 burnsjared0415 force-pushed the bug-r/vsphere_tag_catagory-remove-forceNew branch from 0ddcf22 to 5349c42 Compare September 17, 2024 21:07
@github-actions github-actions bot added the documentation Type: Documentation label Sep 17, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
There was a bug that resulted in the tag being replaced when changing cardinality from Single to Multiple, i have remove the ForceNew.

Signed-off-by: Jared Burns <[email protected]>
@burnsjared0415 burnsjared0415 force-pushed the bug-r/vsphere_tag_catagory-remove-forceNew branch from 5349c42 to 22d0ec1 Compare September 17, 2024 21:22
@tenthirtyam tenthirtyam marked this pull request as ready for review September 18, 2024 13:59
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 18, 2024 13:59
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adding @iBrandyJackson for review.

@tenthirtyam tenthirtyam removed documentation Type: Documentation needs-review Status: Pull Request Needs Review labels Sep 18, 2024
@tenthirtyam tenthirtyam merged commit ed2c85b into hashicorp:main Sep 18, 2024
6 checks passed
Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

1 similar comment
Copy link

github-actions bot commented Oct 8, 2024

This functionality has been released in v2.9.3 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Type: Bug provider Type: Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating tag category cardinality causes error 404
3 participants