Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ntpd service on r/vsphere_host #2232

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: add support for ntpd service on r/vsphere_host #2232

merged 2 commits into from
Aug 14, 2024

Conversation

burnsjared0415
Copy link
Collaborator

@burnsjared0415 burnsjared0415 commented Jul 2, 2024 •
edited by tenthirtyam
Loading

Description

Added support for ntpd for services on r/vsphere_host. This allows for ntpd service settings and policy to be added to a host resource.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Release Note

  • resource/host - Added support for ntpd for services on r/vsphere_host. This allows for ntpd service settings and policy to be added to a host resource and future expansion of additional services.

References

Closes #1131

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner July 2, 2024 16:45
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Jul 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Jul 2, 2024
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from fa9ce05 to e1b8352 Compare July 2, 2024 17:02
@tenthirtyam tenthirtyam added this to the v2.8.3 milestone Jul 2, 2024
@tenthirtyam tenthirtyam changed the title feature: add support for ntpd service on resource_vsphere_host feat: add support for ntpd service on r/host Jul 2, 2024
@tenthirtyam
Copy link
Collaborator

@spacegospod - this is from Jared Burns on my team.

@tenthirtyam tenthirtyam added enhancement Type: Enhancement area/host Area: Host labels Jul 2, 2024
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch 2 times, most recently from 401b3a3 to 9e7e8f6 Compare July 2, 2024 17:20
@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 4484436 to 37db380 Compare July 30, 2024 16:38
@burnsjared0415
Copy link
Collaborator Author

burnsjared0415 commented Jul 30, 2024 via email •
edited by tenthirtyam
Loading

@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 37db380 to 9382986 Compare August 7, 2024 14:28
spacegospod
spacegospod approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

vsphere/resource_vsphere_host.go Show resolved Hide resolved
vsphere/resource_vsphere_host.go Show resolved Hide resolved
vsphere/resource_vsphere_host.go Show resolved Hide resolved
@tenthirtyam tenthirtyam modified the milestones: v2.8.3, v2.8.4 Aug 13, 2024
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch 2 times, most recently from ded1be8 to de0e878 Compare August 14, 2024 13:13
@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from de0e878 to 204ef75 Compare August 14, 2024 13:43
tenthirtyam
tenthirtyam approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam
Copy link
Collaborator

We'll need to resolve the Unit Test failure before merging.

--- FAIL: TestAccResourceVSphereHostNTPServers (0.00s)
[80](https://github.com/hashicorp/terraform-provider-vsphere/actions/runs/10388780504/job/28766449889?pr=2232#step:5:81)    resource_vsphere_host_test.go:439: NTP_SERVERS environment variable is not set

@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 204ef75 to ba61dd8 Compare August 14, 2024 14:18
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch 4 times, most recently from 5702553 to 0f8ff64 Compare August 14, 2024 14:44
@burnsjared0415 @tenthirtyam
feature: add support for ntpd service on resource_vsphere_host
3915223 
Added support for ntpd for services on resource_vsphere_host, this will allow for ntpd service to be added during import of host.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 0f8ff64 to 3915223 Compare August 14, 2024 14:48
@tenthirtyam
Copy link
Collaborator

All tests are passing. Clear to merge.

@tenthirtyam
docs: update CHANGELOG.md
15e555b 
Updates `CHANGELOG.md` for v2.8.4 release.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from faaf52e to 15e555b Compare August 14, 2024 14:59
@tenthirtyam tenthirtyam changed the title feat: add support for ntpd service on r/host feat: add support for ntpd service on r/vsphere_host Aug 14, 2024
@tenthirtyam tenthirtyam merged commit f008950 into hashicorp:main Aug 14, 2024
5 checks passed
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Aug 14, 2024
@tenthirtyam tenthirtyam modified the milestones: v2.8.4, v2.9.0 Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

This functionality has been released in v2.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spacegospod spacegospod spacegospod approved these changes

@iBrandyJackson iBrandyJackson iBrandyJackson approved these changes

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
area/host Area: Host documentation Type: Documentation enhancement Type: Enhancement provider Type: Provider
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

Add support to manage ntpd setting on ESXi hosts
4 participants
@burnsjared0415 @tenthirtyam @iBrandyJackson @spacegospod